Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate Header changes #38

Merged
merged 4 commits into from
Jul 20, 2023
Merged

validate Header changes #38

merged 4 commits into from
Jul 20, 2023

Conversation

schakrad
Copy link
Contributor

No description provided.

@schakrad
validate Header changes
0be9587 
Signed-off-by: schakrad <[email protected]>
leoluz
leoluz requested changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests validating the new functionality.

@schakrad
Copy link
Contributor Author

Test cases included in server_test.go

@schakrad
testcases
c8e6e78 
Signed-off-by: schakrad <[email protected]>
@schakrad
changes
defb7f0 
Signed-off-by: schakrad <[email protected]>
leoluz
leoluz approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit 5d714b0 into argoproj-labs:main Jul 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schakrad @leoluz