hide the legend when line series is empty #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashutosh16
commented
Jun 30, 2023
| }); | ||
| setFilterChart({ ...filterChart, [groupBy]: newFilter }); | ||
| }, [chartData, groupBy, setFilterChart]); | ||
| if (chartData?.length != 0) { |
There was a problem hiding this comment.
Only when chartData is not empty. This would avoid overriding the values
ashutosh16
commented
Jun 30, 2023
| {XAxisMemo} | ||
| {YAxisMemo} | ||
| {TooltipMemo} | ||
| {chartData?.length > 0 ? LegendMemo : null} |
There was a problem hiding this comment.
Show legends only if chartData is not empty
ashutosh16
commented
Jun 30, 2023
|
|
||
| {chartData?.length > 0 ? ( |
There was a problem hiding this comment.
Show message when metrics provider returns no data
ashutosh16
commented
Jun 30, 2023
| @@ -130,7 +130,10 @@ export const ChartWrapper = ({ | |||
| } | |||
| const metricObj: ChartDataProps = { | |||
| ...obj, | |||
| name: obj?.metric && typeof obj?.metric?.pod === 'string' ? obj?.metric?.pod: Object.values(obj?.metric).join(":"), | |||
| name: | |||
| obj?.metric && typeof obj?.metric?.[groupBy] === "string" | |||
There was a problem hiding this comment.
name is based on the metricName config
https://github.com/argoproj-labs/argocd-extension-metrics/blob/main/app/config.json#L44
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the filter based on the groupby
Hide the legend when metrics provide is empty
Show Metric provider not available message when provider return no response