Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display cpu/memory requests and limits #47

Closed
wants to merge 0 commits into from
Closed

feat: display cpu/memory requests and limits #47

wants to merge 0 commits into from

Conversation

schakrad
Copy link
Contributor

@schakrad schakrad commented Aug 4, 2023

No description provided.

@schakrad schakrad changed the title Requests and limits 2 feat: Display cpu/memory Requests and limits Aug 4, 2023
@schakrad schakrad changed the title feat: Display cpu/memory Requests and limits feat: Display cpu/memory requests and limits Aug 4, 2023
leoluz
leoluz requested changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments. The logic to display cpu requests and limits should be based on configuration rather than on metric's name pattern.

extensions/resource-metrics/resource-metrics-extention/ui/src/Metrics/Chart/Chart.tsx Outdated Show resolved Hide resolved
leoluz
leoluz requested changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of introducing a new SubMetric attribute we could maybe leverage the existing Threshold field to accommodate our metrics limit and request use-case. Please check my comment for more details.

server/config.go Outdated Show resolved Hide resolved
@schakrad schakrad changed the title feat: Display cpu/memory requests and limits feat: display cpu/memory requests and limits Aug 23, 2023
leoluz
leoluz requested changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments and add tests validating your changes.

app/config.json Outdated Show resolved Hide resolved
extensions/resource-metrics/resource-metrics-extention/ui/src/Metrics/Chart/Chart.scss Outdated Show resolved Hide resolved
extensions/resource-metrics/resource-metrics-extention/ui/src/Metrics/Chart/Chart.tsx Outdated Show resolved Hide resolved
extensions/resource-metrics/resource-metrics-extention/ui/src/Metrics/client.ts Outdated Show resolved Hide resolved
server/prometheus.go Outdated Show resolved Hide resolved
server/prometheus.go Outdated Show resolved Hide resolved
server/prometheus.go Outdated Show resolved Hide resolved
server/prometheus.go Outdated Show resolved Hide resolved
server/prometheus.go Outdated Show resolved Hide resolved
server/wavefront.go Outdated Show resolved Hide resolved
@leoluz
Copy link
Collaborator

leoluz commented Aug 28, 2023

@schakrad Please update your branch with master as it has a long list of already merged commits. While doing so, make sure to properly fix the two files with conflicts.

@schakrad schakrad closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schakrad @leoluz