feat: add support for separate GitHub app credentials #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #649 +/- ##
==========================================
- Coverage 66.41% 66.27% -0.14%
==========================================
Files 22 22
Lines 2138 2150 +12
==========================================
+ Hits 1420 1425 +5
- Misses 587 591 +4
- Partials 131 134 +3 ☔ View full report in Codecov by Sentry. |
dlactin
force-pushed
the
separate-github-app-credentials
branch
2 times, most recently
from
15573da to
5036e73
Compare
…netes secrets Signed-off-by: Dustin Lactin <[email protected]>
dlactin
force-pushed
the
separate-github-app-credentials
branch
from
5036e73 to
ad6d8a1
Compare
dlactin
changed the title
Signed-off-by: Dustin Lactin <[email protected]>
Signed-off-by: Dustin Lactin <[email protected]>
jannfis
reviewed
Dec 7, 2023
pkg/argocd/gitcreds.go
Outdated
Comment on lines
79
to
80
| intGithubAppID, _ := strconv.ParseInt(string(githubAppID), 10, 64) | ||
| intGithubAppInstallationID, _ := strconv.ParseInt(string(githubAppInstallationID), 10, 64) |
There was a problem hiding this comment.
I think we really should check for error in string-to-number conversion.
There was a problem hiding this comment.
Ah yes, meant to add that after testing. I'll add it now!
Signed-off-by: Dustin Lactin <[email protected]>
jannfis
reviewed
Dec 7, 2023
pkg/argocd/gitcreds.go
Outdated
| // converting byte array to string and ultimately int64 for NewGitHubAppCreds | ||
| intGithubAppID, err := strconv.ParseInt(string(githubAppID), 10, 64) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
Suggested change
| return nil, err | |
| return nil, fmt.Errorf("invalid value in field githubAppID: %w", err) |
just a tiny improvement to help with troubleshooting
There was a problem hiding this comment.
Wasn't sure if I could just commit the suggestions, so I added a new commit for these changes. Thank you!
pkg/argocd/gitcreds.go
Outdated
| } | ||
| intGithubAppInstallationID, _ := strconv.ParseInt(string(githubAppInstallationID), 10, 64) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
Suggested change
| return nil, err | |
| return nil, fmt.Errorf("invalid value in field githubAppInstallationID: %w", err) | |
just a tiny improvement to help with troubleshooting
…rsions Signed-off-by: Dustin Lactin <[email protected]>
dlactin
added a commit
to dlactin/argocd-image-updater
that referenced
this pull request
May 9, 2024
) * feat: add support for separate GitHub app credentials stored as Kubernetes secrets Signed-off-by: Dustin Lactin <[email protected]> * test: added tests for consuming GitHub app credentials from a secret Signed-off-by: Dustin Lactin <[email protected]> * fix: added GitHub App placeholder words to expect.txt Signed-off-by: Dustin Lactin <[email protected]> * fix: checking for errors when converting GitHub App and Installation IDs Signed-off-by: Dustin Lactin <[email protected]> * fix: added more descriptive error messages for string-to-number conversions Signed-off-by: Dustin Lactin <[email protected]> --------- Signed-off-by: Dustin Lactin <[email protected]>
sribiere-jellysmack
pushed a commit
to sribiere-jellysmack/argocd-image-updater
that referenced
this pull request
Aug 13, 2024
) * feat: add support for separate GitHub app credentials stored as Kubernetes secrets Signed-off-by: Dustin Lactin <[email protected]> * test: added tests for consuming GitHub app credentials from a secret Signed-off-by: Dustin Lactin <[email protected]> * fix: added GitHub App placeholder words to expect.txt Signed-off-by: Dustin Lactin <[email protected]> * fix: checking for errors when converting GitHub App and Installation IDs Signed-off-by: Dustin Lactin <[email protected]> * fix: added more descriptive error messages for string-to-number conversions Signed-off-by: Dustin Lactin <[email protected]> --------- Signed-off-by: Dustin Lactin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for separate GitHub app credentials using the pre-existing GitHub App functions