Update references of pkg/tag pkg/log pkg/options to use modules from registry-scanner #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #962 +/- ##
==========================================
- Coverage 73.61% 72.42% -1.19%
==========================================
Files 31 27 -4
Lines 3991 3725 -266
==========================================
- Hits 2938 2698 -240
+ Misses 910 885 -25
+ Partials 143 142 -1 ☔ View full report in Codecov by Sentry. |
ishitasequeira
force-pushed
the
update-references-registry-scanner-pkg-log-options-tag
branch
from
7d3ae87 to
8cf65b4
Compare
…registry-scanner Signed-off-by: Ishita Sequeira <[email protected]>
…module Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
ishitasequeira
force-pushed
the
update-references-registry-scanner-pkg-log-options-tag
branch
from
8cf65b4 to
1c4a6a7
Compare
Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
ishitasequeira
requested review from
jannfis,
chengfang and
pasha-codefresh
as code owners
ishitasequeira
commented
Dec 16, 2024
Comment on lines
+176
to
+177
| // Uncomment for local testing | ||
| // github.com/argoproj-labs/argocd-image-updater/registry-scanner => ./registry-scanner/ |
There was a problem hiding this comment.
Added a comment for stating that we need to uncomment this line for local testing if we have changes in registry-scanner module.
Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
chengfang
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update references of pkg/tag pkg/log pkg/options to use modules from registry-scanner