Improve Application updates when write-back method is ArgoCD #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaguilartablada
requested review from
jannfis,
chengfang,
pasha-codefresh and
ishitasequeira
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
==========================================
- Coverage 74.64% 73.61% -1.04%
==========================================
Files 31 31
Lines 3913 3991 +78
==========================================
+ Hits 2921 2938 +17
- Misses 856 910 +54
- Partials 136 143 +7 ☔ View full report in Codecov by Sentry. |
aaguilartablada
force-pushed
the
master
branch
from
39ca879 to
1b65b95
Compare
chengfang
reviewed
Dec 10, 2024
chengfang
reviewed
Dec 10, 2024
aaguilartablada
force-pushed
the
master
branch
from
7f83501 to
0f06fcb
Compare
chengfang
reviewed
Dec 11, 2024
Signed-off-by: Álvaro Aguilar-Tablada Espinosa <[email protected]>
Signed-off-by: Álvaro Aguilar-Tablada Espinosa <[email protected]>
Signed-off-by: Álvaro Aguilar-Tablada Espinosa <[email protected]>
aaguilartablada
force-pushed
the
master
branch
from
4cc5de5 to
1f859d7
Compare
chengfang
approved these changes
Dec 12, 2024
|
@aaguilartablada thanks for contributing this valuable enhancement! |
chengfang
pushed a commit
to chengfang/argocd-image-updater
that referenced
this pull request
Dec 20, 2024
…j-labs#965) Signed-off-by: Álvaro Aguilar-Tablada Espinosa <[email protected]>
jannfis
pushed a commit
that referenced
this pull request
Dec 20, 2024
…981) Signed-off-by: Álvaro Aguilar-Tablada Espinosa <[email protected]> Co-authored-by: Álvaro Aguilar-Tablada Espinosa <[email protected]>
|
0.15.2 was released on 2025-01-06: https://github.com/argoproj-labs/argocd-image-updater/releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the write-back method is ArgoCD, the Image Updater sends an update to the ArgoCD Application on each iteration. No matter whether the new image has already been set or not, it always sends the update. In a situation where autoSync is disabled, this means that it continuously sends updates until somebody syncs the Application.
To reduce updates and improve resource usage, this pull request slightly changes the behavior. The Image Updater will check if the new image is already set in the Application source to apply the update or ignore it.
We have tested the changes in our ArgoCD instance to check the feature and you can see the results in the image below. Updates have been reduced. Once they are applied, updates disappear. CPU and memory usage have been improved.