Skip to content

Commit

Permalink
Fix a minor issue with script runner when the value itself evaluates …
Browse files Browse the repository at this point in the history
…to a falsey value (#697)

**Pull Request Checklist**
- [ ] Fixes #<!--issue number goes here-->
- [ ] Tests added
- [ ] Documentation/examples added
- [ ] [Good commit messages](https://cbea.ms/git-commit/) and/or PR
title

**Description of PR**
Currently, ...

This PR adds/changes/fixes...

Signed-off-by: Sambhav Kothari <[email protected]>
  • Loading branch information
sambhav authored Jun 26, 2023
1 parent a247c42 commit 0c7d050
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/hera/workflows/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def _runner(entrypoint: str, kwargs_list: Any) -> str:
# convert the kwargs list to a dict
kwargs = {}
for kwarg in kwargs_list:
if not kwarg.get("name") or not kwarg.get("value"):
if "name" not in kwarg or "value" not in kwarg:
continue
# sanitize the key for python
key = serialize(kwarg["name"]).replace("-", "_")
Expand Down

0 comments on commit 0c7d050

Please sign in to comment.