Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): allow terminate sync when sync start and terminate sync apps in list page #19718

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

linghaoSu
Copy link
Contributor

@linghaoSu linghaoSu commented Aug 29, 2024

fix #18549

Add a button to terminate synchronisation more conveniently on the detail page.

cliped-new-720.mov

Add batch terminate sync panel on list page

cliped-480.mov

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@linghaoSu linghaoSu requested a review from a team as a code owner August 29, 2024 03:06
Copy link

bunnyshell bot commented Aug 29, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

bunnyshell bot commented Aug 29, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@linghaoSu linghaoSu marked this pull request as draft August 29, 2024 03:07
@todaywasawesome
Copy link
Contributor

Subscribing 👀

@agaudreault
Copy link
Member

It looks good! I would make the popup more specific to the sync. Maybe "Terminate Sync" instead of "Terminate Operation" because we lose context on what was the operation that we are terminating when the popup is open.

@linghaoSu linghaoSu changed the title fix(ui): allow terminate sync when sync start feat(ui): allow terminate sync when sync start and terminate sync apps in list page Sep 8, 2024
@linghaoSu linghaoSu marked this pull request as ready for review September 8, 2024 09:22
@linghaoSu
Copy link
Contributor Author

It looks good! I would make the popup more specific to the sync. Maybe "Terminate Sync" instead of "Terminate Operation" because we lose context on what was the operation that we are terminating when the popup is open.

@agaudreault Agreed, the description of the pop-up prompt for terminating the sync on the detail page is now a bit more precise

@linghaoSu
Copy link
Contributor Author

Hi,@todaywasawesome @agaudreault I think this feature is ready to be reviewed, can you please help me review this pr?

});

if (replaceChecked && containAppOfApps) {
confirmSyncingAppOfApps(selectedAppOfApps, ctx, currentForm).then(confirmed => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming is a bit confusing. ApplicationsTerminateSyncPanel suggests it's only for termination of sync, so why do we confirm sync and check replace option? If we need to, shall we check prune as well?

@andrii-korotkov-verkada
Copy link
Contributor

@linghaoSu, I've asked for review in CNCF Slack. Can you rebase on the latest master and re-test, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement "Terminate Sync" in web UI applications list view
4 participants