Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: truncated commits accepted during the file comparison #19823

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dr14-make
Copy link

@dr14-make dr14-make commented Sep 6, 2024

Describe the bug:
Application produces a error when short commit SHA is used in target revision

Changes:
Fixes[ISSUE #19820]
Short commit SHA is now accepted in ChangedFiles routine

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@dr14-make dr14-make requested a review from a team as a code owner September 6, 2024 14:35
Copy link

bunnyshell bot commented Sep 6, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-kew7ma.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-kew7ma.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

bunnyshell bot commented Sep 6, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@dr14-make dr14-make force-pushed the use_short_sha_for_change_detection branch from d923d15 to 3ab8707 Compare September 6, 2024 14:37
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@be90cc0). Learn more about missing BASE report.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #19823   +/-   ##
=========================================
  Coverage          ?   55.83%           
=========================================
  Files             ?      320           
  Lines             ?    44281           
  Branches          ?        0           
=========================================
  Hits              ?    24726           
  Misses            ?    16989           
  Partials          ?     2566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant