Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return handleCommitRequest early if already hydrated #19907

Open
wants to merge 1 commit into
base: hydrator
Choose a base branch
from

Conversation

jcy0308
Copy link

@jcy0308 jcy0308 commented Sep 12, 2024

close #19592
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@jcy0308 jcy0308 requested a review from a team as a code owner September 12, 2024 08:15
logCtx.Debug("Checking out if hydrated already")
metadataPath := path.Join(dirPath, "hydrator.metadata")
fileData, err := os.ReadFile(metadataPath)
if err == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if err == nil {
if err != nil {
// handle the error
}
var hydratorMetadata hydratorMetadataFile
json.Unmarshal(fileData, &hydratorMetadata)
if hydratorMetadata.DrySHA == r.DrySha {
logCtx.Debug("Already Hydrated")
return "", r.DrySha, nil
}

Minor but this way we are handling the error too if received when trying to read the file..

Copy link
Contributor

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment but overall looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants