Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Sync Health Statuses for Applications and everything else (#12056) #20020

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(ui): Sync Health Statuses for Applications and everything else (#12056) #20020

merged 1 commit into from
Sep 20, 2024

Conversation

jsoref
Copy link
Member

@jsoref jsoref commented Sep 19, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Fixes #12056

@jsoref jsoref requested a review from a team as a code owner September 19, 2024 22:43
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 19, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 19, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@jsoref
Copy link
Member Author

jsoref commented Sep 19, 2024

As seen on bunnyshell:
image

gdsoumya
gdsoumya requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see it solving the issue with sync statuses, do you plan to add that too?

gdsoumya
gdsoumya approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm I misread the issues. LGTM

@gdsoumya gdsoumya merged commit 9ac1670 into argoproj:master Sep 20, 2024
23 of 24 checks passed
@jsoref jsoref deleted the issue-12056 branch September 20, 2024 17:37
eogns47 pushed a commit to Argo-OSS/argo-cd that referenced this pull request Sep 26, 2024
@jsoref @eogns47
fix(ui): Sync Health Statuses for Applications and everything else (a…
92e0245 
…rgoproj#20020)

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: KangManJoo <[email protected]>
eogns47 pushed a commit to Argo-OSS/argo-cd that referenced this pull request Sep 26, 2024
@jsoref @eogns47
fix(ui): Sync Health Statuses for Applications and everything else (a…
020fda2 
…rgoproj#20020)

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: KangManJoo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitishfy nitishfy nitishfy approved these changes

@gdsoumya gdsoumya gdsoumya approved these changes

@christianh814 christianh814 christianh814 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order of Health Status is different between Applications list and Application view
4 participants
@jsoref @christianh814 @gdsoumya @nitishfy