Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update notification engine to 2fef5c9 #20276

Merged
merged 2 commits into from
Oct 8, 2024
Merged

chore: Update notification engine to 2fef5c9 #20276

merged 2 commits into from
Oct 8, 2024

Conversation

ayatk
Copy link
Contributor

@ayatk ayatk commented Oct 8, 2024

Update argoproj/notifications-engine@2fef5c9

changes:

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@ayatk ayatk requested review from a team as code owners October 8, 2024 01:37
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 8, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 8, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@20e2e78). Learn more about missing BASE report.
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #20276   +/-   ##
=========================================
  Coverage          ?   55.95%           
=========================================
  Files             ?      322           
  Lines             ?    44673           
  Branches          ?        0           
=========================================
  Hits              ?    24996           
  Misses            ?    17087           
  Partials          ?     2590

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nitishfy
nitishfy approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pasha-codefresh pasha-codefresh merged commit 3f249ff into argoproj:master Oct 8, 2024
27 checks passed
@ayatk ayatk deleted the update-notification-engine branch October 8, 2024 09:16
ali-hamza-noor pushed a commit to ali-hamza-noor/argo-cd that referenced this pull request Oct 10, 2024
@ayatk @ali-hamza-noor
chore: Update notification engine to 2fef5c9 (argoproj#20276)
db9f78e 
* Update notification-engine to 2fef5c9049fd

Signed-off-by: ayatk <[email protected]>

* make notification-docs

Signed-off-by: ayatk <[email protected]>

---------

Signed-off-by: ayatk <[email protected]>
Co-authored-by: ayatk <[email protected]>
Signed-off-by: alnoor <[email protected]>
austin5219 pushed a commit to austin5219/argo-cd that referenced this pull request Oct 16, 2024
@ayatk @austin5219
chore: Update notification engine to 2fef5c9 (argoproj#20276)
b69465c 
* Update notification-engine to 2fef5c9049fd

Signed-off-by: ayatk <[email protected]>

* make notification-docs

Signed-off-by: ayatk <[email protected]>

---------

Signed-off-by: ayatk <[email protected]>
Co-authored-by: ayatk <[email protected]>
Signed-off-by: austin5219 <[email protected]>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@ayatk @adriananeci
chore: Update notification engine to 2fef5c9 (argoproj#20276)
cd6fab6 
* Update notification-engine to 2fef5c9049fd

Signed-off-by: ayatk <[email protected]>

* make notification-docs

Signed-off-by: ayatk <[email protected]>

---------

Signed-off-by: ayatk <[email protected]>
Co-authored-by: ayatk <[email protected]>
Signed-off-by: Adrian Aneci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitishfy nitishfy nitishfy approved these changes

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayatk @pasha-codefresh @nitishfy