Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): disable select not running pod and bring back arrow to selected pod #21576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linghaoSu
Copy link
Member

@linghaoSu linghaoSu commented Jan 20, 2025

Summary

Fixes #21621

  1. Disabled the ability to select pods that are not running.
  2. Fixed the issue where the arrow indicating the selected pod loses its style.

Before

image

After

image
image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Jan 20, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@linghaoSu linghaoSu force-pushed the feat/add-disabled-tip-for-terminated-pod branch from 45c0e1b to 1f566ef Compare January 20, 2025 10:53
@linghaoSu linghaoSu marked this pull request as ready for review January 20, 2025 10:53
@linghaoSu linghaoSu requested a review from a team as a code owner January 20, 2025 10:53
@linghaoSu linghaoSu force-pushed the feat/add-disabled-tip-for-terminated-pod branch from 1f566ef to 1a29574 Compare January 20, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visually Differentiate Non-Terminal Accessible Containers
1 participant