Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Kustomize ignore components - issues/18634 #21674

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bradkwadsworth
Copy link

@bradkwadsworth bradkwadsworth commented Jan 26, 2025

Added ability to ignore Kustomize component directory if it does not exist. A new field called ignoreMissingComponents, if enabled, will verify if a given components directory exists and if not will log a debug message. Only found component directories will be used if ignoreMissingComponents is set to true.

Fixes #18634

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bradkwadsworth bradkwadsworth requested a review from a team as a code owner January 26, 2025 21:53
Copy link

bunnyshell bot commented Jan 26, 2025

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-vvfhj5.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-vvfhj5.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@bradkwadsworth bradkwadsworth force-pushed the feature/ignore-missing-components branch from 8272cf6 to aaf19de Compare January 26, 2025 21:56
Signed-off-by: Brad Wadsworth <[email protected]>
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@544aea1). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #21674   +/-   ##
=========================================
  Coverage          ?   55.38%           
=========================================
  Files             ?      339           
  Lines             ?    57192           
  Branches          ?        0           
=========================================
  Hits              ?    31678           
  Misses            ?    22840           
  Partials          ?     2674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Brad Wadsworth <[email protected]>
@bradkwadsworth bradkwadsworth requested a review from a team as a code owner January 26, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support optional components/patches in kustomize applications (similar to ignoreMissingValueFiles for helm)
1 participant