fix(argo-cd): Fix Redis race condition due to optional REDIS_PASSWORD #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yu-croco <[email protected]>
yu-croco
requested review from
mbevc1,
mkilchhofer,
jmeridth,
pdrastil and
tico24
as code owners
|
When will this PR be merged? At this moment ArgoCD does not function after an inital install. A restart of the deployments helps as a workaround but it would be nice if this PR was merged. |
yu-croco
force-pushed
the
fix-redis-secret
branch
from
365d518
to
1927a49
Compare
mbevc1
approved these changes
Aug 8, 2024
|
Is this still a draft @yu-croco? That's why I've been avoiding reviewing. |
|
I've been waiting for the reply in #2836 (comment), but we cannot get it. So let us go proceed. |
tico24
approved these changes
Aug 8, 2024
|
If we cannot get a reply, I agree let's go ahead and merge this. Feels like the risk is fairly low. |
|
Thank you! |
rouke-broersma
referenced
this pull request
in broersma-forslund/homelab
Aug 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [argo-cd](https://togithub.com/argoproj/argo-helm) | patch | `7.4.1` -> `7.4.2` | --- ### Release Notes <details> <summary>argoproj/argo-helm (argo-cd)</summary> ### [`v7.4.2`](https://togithub.com/argoproj/argo-helm/releases/tag/argo-cd-7.4.2) A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes. ##### What's Changed - fix(argo-cd): Fix Redis race condition due to optional REDIS_PASSWORD by [@​yu-croco](https://togithub.com/yu-croco) in [https://github.com/argoproj/argo-helm/pull/2839](https://togithub.com/argoproj/argo-helm/pull/2839) **Full Changelog**: argoproj/argo-helm@argo-cd-7.4.1...argo-cd-7.4.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/broersma-forslund/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
|
Btw, this didn't fix #2836 from what I can tell (see comments there) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2836
Checklist: