feat(argo-cd): conditional namespace support to ClusterRoleBinding #2934
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: leehosu <[email protected]>
Signed-off-by: leehosu <[email protected]>
leehosu
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
leehosu
changed the title
yu-croco
reviewed
Sep 23, 2024
…eparated string Signed-off-by: leehosu <[email protected]>
Signed-off-by: leehosu <[email protected]>
Signed-off-by: leehosu <[email protected]>
leehosu
changed the title
leehosu
changed the title
leehosu
changed the title
Signed-off-by: leehosu <[email protected]>
yu-croco
reviewed
Sep 24, 2024
charts/argo-cd/templates/argocd-application-controller/clusterrolebinding.yaml
Outdated
Show resolved
Hide resolved
yu-croco
reviewed
Sep 24, 2024
Co-authored-by: Aikawa <[email protected]> Signed-off-by: l2h <[email protected]>
…plitting and quoting. Signed-off-by: leehosu <[email protected]>
Signed-off-by: leehosu <[email protected]>
…ller.namespaces parameter Signed-off-by: leehosu <[email protected]>
yu-croco
reviewed
Sep 24, 2024
| @@ -13,4 +13,12 @@ subjects: | |||
| - kind: ServiceAccount | |||
| name: {{ include "argo-cd.controller.serviceAccountName" . }} | |||
| namespace: {{ include "argo-cd.namespace" . }} | |||
| {{- $namespaces := index .Values.configs.params "applicationsetcontroller.namespaces" -}} | |||
There was a problem hiding this comment.
Though I was distracted about the logic itself, the original issue ( #2919 ) is about argocd-applicationset-controller sa, not argocd-application-controllersa.
Are you sure that here is the right place to add code?
There was a problem hiding this comment.
Oh. I was mistaken. I'll close the PR, and I'll work on the argocd-applicationset-controller with the same logic and post the PR again. Thanks for the attention.
leehosu
restored the
feat/config-applicationsetcontroller-namespaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #2919
Checklist: