Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-workflows): Add unhealthyPodEvictionPolicy to workflow controller PDB #3012

Closed
wants to merge 1 commit into from
Closed

fix(argo-workflows): Add unhealthyPodEvictionPolicy to workflow controller PDB #3012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion charts/argo-workflows/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: v3.5.12
name: argo-workflows
description: A Helm chart for Argo Workflows
type: application
version: 0.42.7
version: 0.42.8
icon: https://argo-workflows.readthedocs.io/en/stable/assets/logo.png
home: https://github.com/argoproj/argo-helm
sources:
Expand All @@ -18,3 +18,5 @@ annotations:
artifacthub.io/changes: |
- kind: added
description: Support lifecycle and terminationGracePeriodSeconds for server
Comment on lines 19 to 20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove old one.

- kind: added
description: explicitly set unhealthyPodEvictionPolicy to IfHealthyBudget in controller PDB
3 changes: 3 additions & 0 deletions charts/argo-workflows/templates/controller/workflow-controller-deployment-pdb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ spec:
{{- else }}
minAvailable: 0
{{- end }}
{{- if .Values.controller.pdb.unhealthyPodEvictionPolicy }}
unhealthyPodEvictionPolicy: {{ .Values.controller.pdb.unhealthyPodEvictionPolicy }}
{{- end }}
selector:
matchLabels:
{{- include "argo-workflows.selectorLabels" (dict "context" . "name" .Values.controller.name) | nindent 6 }}
Expand Down
3 changes: 3 additions & 0 deletions charts/argo-workflows/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,9 @@ controller:
# minAvailable: 1
# maxUnavailable: 1

# -- [unhealthyPodEvictionPolicy] generally available since k8s v1.31+
# unhealthyPodEvictionPolicy: IfHealthyBudget

# -- [Node selector]
nodeSelector:
kubernetes.io/os: linux
Expand Down