-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Relic canary verification #3771
Comments
Does this require any change to argo rollouts today? |
@zachaller Thanks for the response. This doesn't require any change to argo rollouts today 😀 What's the best way to share this code? |
Would it make sense as a community project with a collection of Analysis Templates? That could be useful practically, and as an examples tools. |
As discussed in the contributor meeting, I'm going to go with modifying the documentation |
closes: argoproj#3771 Co-authored-by: Abhishek Gaikwad <[email protected]>
closes: argoproj#3771 Co-authored-by: Abhishek Gaikwad <[email protected]> Signed-off-by: Aleksander Korzyński <[email protected]>
closes: argoproj#3771 Co-authored-by: Abhishek Gaikwad <[email protected]> Signed-off-by: Aleksander Korzynski <[email protected]>
closes: argoproj#3771 Co-authored-by: Abhishek Gaikwad <[email protected]> Signed-off-by: Aleksander Korzynski <[email protected]>
closes: argoproj#3771 Co-authored-by: Abhishek Gaikwad <[email protected]> Signed-off-by: Aleksander Korzynski <[email protected]>
closes: argoproj#3771 Co-authored-by: Abhishek Gaikwad <[email protected]> Signed-off-by: Aleksander Korzynski <[email protected]>
closes: argoproj#3771 Co-authored-by: Abhishek Gaikwad <[email protected]> Signed-off-by: Aleksander Korzynski <[email protected]>
closes: argoproj#3771 Co-authored-by: Abhishek Gaikwad <[email protected]> Signed-off-by: Aleksander Korzynski <[email protected]>
Please approve the PR |
Summary
Analysis templates for New Relic canary verification using response time and error rate.
Motivation
Canary verification is most useful when it's automatic. Statistical analysis using averages and standard deviation can be used to detect anomalies in the response time and error rate. New Relic is an observability tool with its own query language NRQL. Generic reusable queries for canary analysis would be useful to the community.
Proposal
The implementation described below has been used for around nine months in production at Priceline.com.
Use Cases
Users of New Relic that want to increase software quality by using of automatic canary verification.
Security Considerations
The New Relic token needs to be stored in a secret in each namespace where canaries are to be deployed.
Risks and Mitigations
Some tuning of the parameters may be required for a given application to prevent false positives and negatives.
Goals
Provide analysis templates for response time and error rate analysis.
Non-Goals
Deploying the New Relic token is outside of scope of this proposal.
Implementation
Response time analysis template:
Error rate analysis template:
Examples
Please find below an example of a Rollout definition:
Upgrade/Downgrade Strategy
There is no impact for users who don't use this feature.
Drawbacks
Currently unknown ;)
Alternatives
A New Relic metric provider is available in Argo Rollouts, but it isn't used in this implementation, as the standard web provider will suffice.
Authors
Message from the maintainers:
Impacted by this missing feature? Give it a 👍. We prioritize the issues with the most 👍.
The text was updated successfully, but these errors were encountered: