-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add New Relic templates #3795
base: master
Are you sure you want to change the base?
Conversation
Published E2E Test Results 4 files 4 suites 3h 26m 8s ⏱️ For more details on these failures, see this check. Results for commit be475f2. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3795 +/- ##
==========================================
- Coverage 84.00% 83.98% -0.03%
==========================================
Files 162 162
Lines 18517 18517
==========================================
- Hits 15556 15551 -5
- Misses 2100 2103 +3
- Partials 861 863 +2 ☔ View full report in Codecov by Sentry. |
Published Unit Test Results2 263 tests 2 263 ✅ 2m 58s ⏱️ Results for commit be475f2. ♻️ This comment has been updated with latest results. |
14f1d80
to
dd51ef5
Compare
dd51ef5
to
5d749d2
Compare
closes: argoproj#3771 Co-authored-by: Abhishek Gaikwad <[email protected]> Signed-off-by: Aleksander Korzynski <[email protected]>
5d749d2
to
be475f2
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your collaboration!
This doc was mainly targeting how to define AnalysisTemplates using the built in NewRelic metrics provider. You are documenting how to achieve the same using the web provider. We want to keep the simple with the built in provider use case as the main target of this document.
The suggestions are:
- add the big yamls in the examples folder
- explain at the bottom of this document what are the advantages of using the web provider and reference the examples
closes: #3771
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.