Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add New Relic templates #3795

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akorzynski
Copy link

@akorzynski akorzynski commented Aug 15, 2024

closes: #3771

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Aug 15, 2024

Published E2E Test Results

  4 files    4 suites   3h 26m 8s ⏱️
112 tests 101 ✅  7 💤 4 ❌
456 runs  420 ✅ 28 💤 8 ❌

For more details on these failures, see this check.

Results for commit be475f2.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (c1ffa8e) to head (be475f2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3795      +/-   ##
==========================================
- Coverage   84.00%   83.98%   -0.03%     
==========================================
  Files         162      162              
  Lines       18517    18517              
==========================================
- Hits        15556    15551       -5     
- Misses       2100     2103       +3     
- Partials      861      863       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 15, 2024

Published Unit Test Results

2 263 tests   2 263 ✅  2m 58s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit be475f2.

♻️ This comment has been updated with latest results.

@akorzynski akorzynski force-pushed the feat/new-relic-templates branch 2 times, most recently from 14f1d80 to dd51ef5 Compare August 16, 2024 16:54
@akorzynski akorzynski changed the title feat(docs): add New Relic templates docs: add New Relic templates, closes: #3771 Aug 16, 2024
@akorzynski akorzynski changed the title docs: add New Relic templates, closes: #3771 docs: add New Relic templates Aug 16, 2024
@akorzynski akorzynski force-pushed the feat/new-relic-templates branch from dd51ef5 to 5d749d2 Compare August 16, 2024 16:57
@akorzynski akorzynski marked this pull request as ready for review August 16, 2024 17:46
closes: argoproj#3771

Co-authored-by: Abhishek Gaikwad <[email protected]>
Signed-off-by: Aleksander Korzynski <[email protected]>
@akorzynski akorzynski force-pushed the feat/new-relic-templates branch from 5d749d2 to be475f2 Compare August 17, 2024 07:22
Copy link

leoluz
leoluz previously approved these changes Sep 5, 2024
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz dismissed their stale review September 5, 2024 15:55

need to take a second look

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your collaboration!
This doc was mainly targeting how to define AnalysisTemplates using the built in NewRelic metrics provider. You are documenting how to achieve the same using the web provider. We want to keep the simple with the built in provider use case as the main target of this document.
The suggestions are:

  • add the big yamls in the examples folder
  • explain at the bottom of this document what are the advantages of using the web provider and reference the examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Relic canary verification
2 participants