Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rollout's selector field should be immutable #3626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chetan-rns
Copy link
Member

Fixes: #2105 #1761

Add a CEL validation to:

  • Make the selector field required
  • Make the selector field immutable.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Jun 11, 2024

Go Published Test Results

2 164 tests   2 163 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        1 ❌

For more details on these failures, see this check.

Results for commit e1437c4.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 11, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 23m 17s ⏱️
111 tests  95 ✅  6 💤  10 ❌
614 runs  400 ✅ 24 💤 190 ❌

For more details on these failures, see this check.

Results for commit e1437c4.

♻️ This comment has been updated with latest results.

@zachaller zachaller added this to the v1.8 milestone Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.26%. Comparing base (f656735) to head (6a1a1a2).

Current head 6a1a1a2 differs from pull request most recent head e1437c4

Please upload reports for the commit e1437c4 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3626      +/-   ##
==========================================
- Coverage   80.27%   80.26%   -0.01%     
==========================================
  Files         156      156              
  Lines       17966    17969       +3     
==========================================
+ Hits        14422    14423       +1     
- Misses       2631     2634       +3     
+ Partials      913      912       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.8% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation to avoid changes to the Rollout selector field
2 participants