-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller): Allow specifying full annotations for nginx canary ingresses. #3671
Conversation
Go Published Test Results2 174 tests 2 174 ✅ 2m 54s ⏱️ Results for commit ceab8d5. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3671 +/- ##
==========================================
+ Coverage 78.15% 78.19% +0.04%
==========================================
Files 157 157
Lines 22501 22507 +6
==========================================
+ Hits 17585 17599 +14
+ Misses 4002 3995 -7
+ Partials 914 913 -1 ☔ View full report in Codecov by Sentry. |
E2E Tests Published Test Results 4 files 4 suites 3h 27m 48s ⏱️ For more details on these failures, see this check. Results for commit ceab8d5. ♻️ This comment has been updated with latest results. |
Signed-off-by: cyrilico <[email protected]>
Signed-off-by: cyrilico <[email protected]>
Signed-off-by: cyrilico <[email protected]>
Signed-off-by: cyrilico <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some more docs as per the comment but LGTM otherwise!
Signed-off-by: cyrilico <[email protected]>
Quality Gate failedFailed conditions |
Testing Published Test Results 5 files 123 suites 3h 32m 30s ⏱️ For more details on these failures, see this check. Results for commit 0ea82eb. |
…ingresses. (argoproj#3671) * refactor according to suggestions Signed-off-by: cyrilico <[email protected]> * codegen Signed-off-by: cyrilico <[email protected]> * missing codegen Signed-off-by: cyrilico <[email protected]> * Update specification.md Signed-off-by: cyrilico <[email protected]> * further clarify when to use new field Signed-off-by: cyrilico <[email protected]> --------- Signed-off-by: cyrilico <[email protected]>
Fixes #2225, fixes #3574
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.