Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): Allow specifying full annotations for nginx canary ingresses. #3671

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Conversation

cyrilico
Copy link
Contributor

@cyrilico cyrilico commented Jun 25, 2024

Fixes #2225, fixes #3574

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

Copy link
Contributor

github-actions bot commented Jun 25, 2024

Go Published Test Results

2 174 tests   2 174 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit ceab8d5.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.19%. Comparing base (d3d630d) to head (0ea82eb).
Report is 68 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3671      +/-   ##
==========================================
+ Coverage   78.15%   78.19%   +0.04%     
==========================================
  Files         157      157              
  Lines       22501    22507       +6     
==========================================
+ Hits        17585    17599      +14     
+ Misses       4002     3995       -7     
+ Partials      914      913       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 25, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 27m 48s ⏱️
111 tests 100 ✅  6 💤 5 ❌
452 runs  420 ✅ 24 💤 8 ❌

For more details on these failures, see this check.

Results for commit ceab8d5.

♻️ This comment has been updated with latest results.

@zachaller zachaller added this to the v1.8 milestone Jun 27, 2024
@cyrilico cyrilico requested a review from zachaller June 27, 2024 22:18
@cyrilico cyrilico closed this Jul 20, 2024
@cyrilico cyrilico reopened this Jul 20, 2024
@cyrilico cyrilico closed this Jul 20, 2024
@cyrilico cyrilico reopened this Jul 20, 2024
Signed-off-by: cyrilico <[email protected]>
@cyrilico cyrilico changed the title fix(controller): Do not consider annotationPrefix when another annotation already present. fix(controller): Allow specifying full annotations for nginx canary ingresses. Jul 20, 2024
Signed-off-by: cyrilico <[email protected]>
@cyrilico cyrilico requested a review from agrawroh July 20, 2024 18:36
Signed-off-by: cyrilico <[email protected]>
@zachaller zachaller changed the title fix(controller): Allow specifying full annotations for nginx canary ingresses. feat(controller): Allow specifying full annotations for nginx canary ingresses. Jul 23, 2024
Copy link
Member

@agrawroh agrawroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some more docs as per the comment but LGTM otherwise!

@cyrilico cyrilico requested a review from agrawroh July 25, 2024 09:32
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
62.7% Duplication on New Code (required ≤ 40%)

See analysis details on SonarCloud

Copy link
Contributor

Testing Published Test Results

    5 files    123 suites   3h 32m 30s ⏱️
2 285 tests 2 275 ✅  6 💤  4 ❌
2 628 runs  2 594 ✅ 24 💤 10 ❌

For more details on these failures, see this check.

Results for commit 0ea82eb.

@zachaller zachaller merged commit 872f2ac into argoproj:master Jul 25, 2024
23 checks passed
nikoshet pushed a commit to nikoshet/argo-rollouts that referenced this pull request Jul 25, 2024
…ingresses. (argoproj#3671)

* refactor according to suggestions

Signed-off-by: cyrilico <[email protected]>

* codegen

Signed-off-by: cyrilico <[email protected]>

* missing codegen

Signed-off-by: cyrilico <[email protected]>

* Update specification.md

Signed-off-by: cyrilico <[email protected]>

* further clarify when to use new field

Signed-off-by: cyrilico <[email protected]>

---------

Signed-off-by: cyrilico <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants