-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support kustomize v5 labels transformer. Fixes #3105 #3775
Conversation
…r kustomize v5 Signed-off-by: Jethro Lee <[email protected]>
Signed-off-by: Hidetake Iwata <[email protected]>
Signed-off-by: Hidetake Iwata <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff to rollout-transform.yaml
--- docs/features/kustomize/rollout-transform.yaml 2024-08-07 18:33:37
+++ docs/features/kustomize/rollout-transform-kustomize-v5.yaml 2024-08-07 18:49:48
@@ -203,6 +203,11 @@
create: false
kind: Rollout
+templateLabels:
+- path: spec/template/metadata/labels
+ create: true
+ kind: Rollout
+
# https://github.com/kubernetes-sigs/kustomize/blob/master/api/konfig/builtinpluginconsts/commonannotations.go
commonAnnotations:
- path: spec/template/metadata/annotations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Published E2E Test Results 4 files 4 suites 3h 32m 29s ⏱️ For more details on these failures, see this check. Results for commit b7d5d53. |
Published Unit Test Results2 176 tests 2 176 ✅ 2m 55s ⏱️ Results for commit b7d5d53. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3775 +/- ##
==========================================
+ Coverage 84.24% 84.26% +0.02%
==========================================
Files 154 154
Lines 18022 18022
==========================================
+ Hits 15182 15187 +5
+ Misses 1998 1995 -3
+ Partials 842 840 -2 ☔ View full report in Codecov by Sentry. |
This resolves #3105.
It contains the following commits:
I have tested this change using below kustomization.yaml.
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.