Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update ephemeral-metadata.md with a small fix #3782

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

areitz
Copy link
Contributor

@areitz areitz commented Aug 10, 2024

A small grammatical fix.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

A small grammatical fix.

Signed-off-by: Andy Reitz <[email protected]>
Copy link

Copy link
Contributor

Published E2E Test Results

  4 files    4 suites   3h 24m 48s ⏱️
112 tests 101 ✅  7 💤 4 ❌
452 runs  420 ✅ 28 💤 4 ❌

For more details on these failures, see this check.

Results for commit 588d150.

Copy link
Contributor

Published Unit Test Results

2 257 tests   2 257 ✅  2m 58s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 588d150.

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.99%. Comparing base (825a7ca) to head (588d150).
Report is 65 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3782      +/-   ##
==========================================
+ Coverage   83.97%   83.99%   +0.02%     
==========================================
  Files         161      161              
  Lines       18492    18492              
==========================================
+ Hits        15528    15532       +4     
+ Misses       2100     2098       -2     
+ Partials      864      862       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaller zachaller merged commit 8f74229 into argoproj:master Aug 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants