Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify supported deployment strategies #3823

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

johnmwood
Copy link
Contributor

@johnmwood johnmwood commented Sep 5, 2024

The current concept docs seem to suggest that Recreate and RollingUpdate deployment strategies are supported by Argo Rollouts:

To make it clear how the Argo Rollouts will behave, here are the descriptions of the various deployment strategies implementations offered by the Argo Rollouts.

I changed the wording in this PR to make the supported APIs more clear. This line caused some confusion on our end because we believed that users had the option to use Recreate or RollingUpdate strategies and we wanted to reject any Rollout admissions with those strategies.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Published E2E Test Results

  4 files    4 suites   3h 14m 45s ⏱️
113 tests 103 ✅  7 💤 3 ❌
458 runs  424 ✅ 28 💤 6 ❌

For more details on these failures, see this check.

Results for commit a1f8988.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Published Unit Test Results

2 275 tests   2 275 ✅  2m 58s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit a1f8988.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (ff93786) to head (a1f8988).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3823   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         163      163           
  Lines       18560    18560           
=======================================
  Hits        15565    15565           
  Misses       2121     2121           
  Partials      874      874           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 26, 2024

@zachaller zachaller merged commit 9b60eca into argoproj:master Sep 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants