-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(analysis): prevent promotion on inconclusive background run. Fixes: #3850 #3873
base: master
Are you sure you want to change the base?
fix(analysis): prevent promotion on inconclusive background run. Fixes: #3850 #3873
Conversation
Published E2E Test Results 4 files 4 suites 3h 11m 24s ⏱️ For more details on these failures, see this check. Results for commit 3fee5f0. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 293 tests 2 293 ✅ 2m 59s ⏱️ Results for commit 3fee5f0. ♻️ This comment has been updated with latest results. |
657372c
to
6070c29
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3873 +/- ##
==========================================
+ Coverage 82.69% 82.70% +0.01%
==========================================
Files 163 163
Lines 22886 22889 +3
==========================================
+ Hits 18925 18931 +6
+ Misses 3087 3084 -3
Partials 874 874 ☔ View full report in Codecov by Sentry. |
Seems like one of the non-required tests failed because of the 500 error response from the yarn registry: Probably it's a good idea to re-run it before merging just in case by someone who can trigger that test manually. |
7104595
to
b833028
Compare
Quality Gate passedIssues Measures |
36a86ba
to
e884c6d
Compare
Signed-off-by: Yurii Popivniak <[email protected]>
Signed-off-by: Yurii Popivniak <[email protected]>
Signed-off-by: Yurii Popivniak <[email protected]>
e884c6d
to
3fee5f0
Compare
Quality Gate passedIssues Measures |
The current patch is applied for background analysis runs. It fixes unexpected promotion of a Rollout on the canary pause step and background analysis run with
Inconclusive
results. Instead of promoting onInconclusive
result reconciler must keepPause
phase/status of the Rollout for manual intervention (promote/abort) similarly to step analysis runs.In addition, the PR adds an end-to-end test for this specific edge case.
Fixes: #3850
Current behavior:
Expected behavior:
To reproduce the described issue without a patch and with the new end-to-end test, it can be run separately on the commit:
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.