Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Reduce Cardinality for controller_clientset_k8s_request_total metrics #3929

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ben-childs-docusign
Copy link

@ben-childs-docusign ben-childs-docusign commented Nov 1, 2024

Following on from #2851

We see very high cardinality for these 3 additional objects (experiments, analysisruns and jobs). So much so that our argo-rollouts controller runs out of memory and restarts after a week or two.

image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Ben Childs <[email protected]>
@ben-childs-docusign ben-childs-docusign force-pushed the bc--highcardinalitymetrics branch from 8e35c3d to 4ea9abf Compare November 1, 2024 19:14
@ben-childs-docusign ben-childs-docusign changed the title fix(controller): Reduce Cardinatlity for controller_clientset_k8s_request_total metrics fix(controller): Reduce Cardinality for controller_clientset_k8s_request_total metrics Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Published E2E Test Results

  4 files    4 suites   3h 18m 9s ⏱️
113 tests 102 ✅  7 💤 4 ❌
456 runs  424 ✅ 28 💤 4 ❌

For more details on these failures, see this check.

Results for commit 8319b61.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Published Unit Test Results

2 280 tests   2 280 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 8319b61.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.72%. Comparing base (53c4f12) to head (8319b61).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3929      +/-   ##
==========================================
+ Coverage   82.66%   82.72%   +0.05%     
==========================================
  Files         163      163              
  Lines       22895    22895              
==========================================
+ Hits        18927    18940      +13     
+ Misses       3092     3083       -9     
+ Partials      876      872       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Nov 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant