Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): add protocol tcp for workaround ComparisonError. #3954

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mztnnrt
Copy link

@mztnnrt mztnnrt commented Nov 16, 2024

Hi, as for the community, we are grateful for your daily contributions.

Now we are using argo-rollouts and argo-cd, when apply the sample code, we have the error which is displayed argo-cd console.

Failed to compare desired state to live state: failed to calculate diff from cache: error calculating structured merge diff: error building typed value from config resource: .spec.template.spec.containers[0].ports: element 0: associative list with keys has an element that omits key field "protocol" (and doesn't have default value)

So we add the protocol, If it is suitable for merging, please merge it.


Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@mztnnrt mztnnrt changed the title chore: add protocol tcp for workaround ComparisonError. fix(docs): add protocol tcp for workaround ComparisonError. Nov 16, 2024
@mztnnrt mztnnrt changed the title fix(docs): add protocol tcp for workaround ComparisonError. fix(example): add protocol tcp for workaround ComparisonError. Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (5f59344) to head (ceef9c6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3954      +/-   ##
==========================================
- Coverage   82.69%   82.69%   -0.01%     
==========================================
  Files         163      163              
  Lines       22895    22895              
==========================================
- Hits        18934    18933       -1     
- Misses       3087     3088       +1     
  Partials      874      874              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Published E2E Test Results

  4 files    4 suites   3h 14m 24s ⏱️
113 tests 102 ✅  7 💤 4 ❌
458 runs  424 ✅ 28 💤 6 ❌

For more details on these failures, see this check.

Results for commit ceef9c6.

Copy link
Contributor

Published Unit Test Results

2 280 tests   2 280 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit ceef9c6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant