fix!: remove deprecated durationMs prop (#577)

- I previously left in `durationMs` for backward-compatibility so that you could use either, but I forgot to mark the types as optional, so both ended up being required by the typings - instead of making them both confusingly optional (no way of doing "one of"), just remove the deprecated `durationMs` in another breaking change Signed-off-by: Anton Gilgur <[email protected]>
argoproj · Sep 12, 2024 · d9a4285 · d9a4285
1 parent e76346f
commit d9a4285
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/components/duration.tsx b/src/components/duration.tsx
@@ -6,8 +6,7 @@ import { formatDuration } from '../../v2';
  * Output a string duration from a number of seconds
  *
  * @param {number} props.durationS - The number of seconds.
- * @param {number} props.durationMs - The number of seconds. DEPRECATED: The "Ms" suffix is incorrect, use props.durationS instead.
  */
-export function Duration(props: {durationMs: number, durationS: number}) {
-    return <span>{formatDuration(props.durationMs || props.durationS, 2)}</span>;
+export function Duration(props: {durationS: number}) {
+    return <span>{formatDuration(props.durationS, 2)}</span>;
 }