chore(deps): dedupe yarn.lock, add check for dupes
#571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
type/dependencies
|
Ah a build failure in the deps, same as the ones I dealt with heavily manually before 🫠 This one appears to be in the dep: iarna/wide-align#63. Will resolve to a lower version instead of a higher one from the dedupe to get around it |
|
Can you rebase? |
agilgur5
force-pushed
the
chore-deps-dedupe
branch
from
37638cc
to
8b6b879
Compare
|
Rebased. |
|
Sorry, gotta ask for another rebase 😆 |
- add a `deduplicate` script that uses `yarn-deduplicate` - run `deduplicate` during UI CI - run `deduplicate` once and commit the results - similar to a PR I made in Workflows and PRs in other repos Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
agilgur5
force-pushed
the
chore-deps-dedupe
branch
from
8b6b879
to
1aafa8a
Compare
|
Rebased once more 😅 |
crenshaw-dev
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent to argoproj/argo-workflows#11637 and PRs I've made in other repos
Motivation
Same as downstream et al, see https://github.com/atlassian/yarn-deduplicate#why-is-this-necessary
Removes ~2.5k+ LoC from the
yarn.lockby consolidating duplicated deps (and saves on disk, installation, network, dep issues, etc)In particular for this repo, all the dep removals and changes I've done for #569 #534 #567 etc have complicated
yarn.lockdiffs that I've manually reduced (sometimes a removal even causes an addition becauseyarnjust adds the latest version of the dep). This does it automatically and will ensure it doesn't happen again.I've wanted to do it for a while but it usually merge conflicts with any other dep changes so I kept deferring it and then forgetting it 😅 There should be a lot less of those after #537 though (dependabot also most certainly contributed to duped deps)
Modifications
add a
deduplicatescript that usesyarn-deduplicaterun
deduplicateduring UI CIrun
deduplicateonce and commit the resultsmove the
buildscript to be in the equivalent place as thebuild-v2script, afterstart/start-v2Verification
yarn deduplicatedoes not cause another diffyarn startis still broken until fix(deps-dev): downgrade all Storybook breakage from dependabot et al #567 is merged)