refactor(ui): simplify hasArtifactLogs with optional chaining (#12933)

Signed-off-by: Anton Gilgur <[email protected]>
argoproj · Apr 16, 2024 · 4319608 · 4319608
1 parent ea5410a
commit 4319608
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/ui/src/app/shared/services/workflows-service.ts b/ui/src/app/shared/services/workflows-service.ts
@@ -20,12 +20,7 @@ function isNodePendingOrRunning(node: NodeStatus) {
 
 function hasArtifactLogs(workflow: Workflow, nodeId: string, container: string) {
     const node = workflow.status.nodes[nodeId];
-
-    if (!node || !node.outputs || !node.outputs.artifacts) {
-        return false;
-    }
-
-    return node.outputs.artifacts.findIndex(a => a.name === `${container}-logs`) !== -1;
+    return node?.outputs?.artifacts?.some(a => a.name === `${container}-logs`);
 }
 
 export const WorkflowsService = {