Skip to content

Commit

Permalink
ci: better comment
Browse files Browse the repository at this point in the history
Signed-off-by: Mason Malone <[email protected]>
  • Loading branch information
MasonM committed Dec 23, 2024
1 parent a7105b4 commit 540a5ec
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,10 @@ jobs:
python-version: '3.x'
cache: pip
- name: Install socat (needed by Kubernetes) and kit
# socat is needed for "kubectl port-forward" to work when using cri-dockerd: https://github.com/k3s-io/cri-dockerd/blob/4995f339edcffdf890406b3f1477d34e38477f18/streaming/streaming_others.go#L46
# Both cri-o and containerd removed it as a dependency awhile ago, but that hasn't been ported to cri-dockerd.
# Running "make kit" isn't strictly necessary, since it would be installed automatically by "make start",
# but it's noisy and makes the logs for "Start controller/API" hard to follow.
run: sudo apt-get -y install socat && make kit
- name: Install and start K3S
run: |
Expand Down

0 comments on commit 540a5ec

Please sign in to comment.