Skip to content

Commit

Permalink
add a note on backporting older commits to resolve merge conflicts as…
Browse files Browse the repository at this point in the history
… well

Signed-off-by: Anton Gilgur <[email protected]>
  • Loading branch information
agilgur5 committed Sep 21, 2024
1 parent 4b9b806 commit 6e172a0
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions docs/releasing.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ Then look for `failed to cherry-pick` in the log to find commits with merge conf
If you're not sure how to fix a merge conflict, the safest and least risky option is to _not_ cherry-pick the commit.
The commit can be revisited in the future if there is user demand or if necessary to prevent further conflicts.

Sometimes merge conflicts occur because a `build`, `chore`, `refactor` or other older commit was not previously cherry-picked.
You can cherry-pick the older commit in order to easily resolve the merge conflict.

If you do make a manual patch, add a note in the commit message of what you changed.
As prior examples, see: [`f19d6d6046`](https://github.com/argoproj/argo-workflows/commit/f19d6d60462fb23c95324ba924c0972d92465a67), [`fbc56d423d`](https://github.com/argoproj/argo-workflows/commit/fbc56d423d106610f899cd487c3bb4ae10a5e3d8), [`37c87dafee`](https://github.com/argoproj/argo-workflows/commit/37c87dafeed5f50ce96664d80009e7d9b4d23e0a)

Expand Down

0 comments on commit 6e172a0

Please sign in to comment.