Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add user info to suspended node when resuming #11763

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

toyamagu-2021
Copy link
Member

@toyamagu-2021 toyamagu-2021 commented Sep 6, 2023

Signed-off-by: toyamagu-2021 [email protected]

Relates #11148

Motivation

  • Add resumer on suspended nodes message for auditing, and tracing purposes.

Modifications

  • Add message about resumed user to node status when resuming workflow.

Verification

  • image

@toyamagu-2021 toyamagu-2021 force-pushed the fix-111148 branch 5 times, most recently from cd46f7f to 6791c6a Compare September 6, 2023 16:09
@toyamagu-2021 toyamagu-2021 marked this pull request as ready for review September 6, 2023 17:49
@agilgur5 agilgur5 added the area/suspend-resume Suspending and resuming workflows label Sep 8, 2023
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be feature instead of fix?

@toyamagu-2021 toyamagu-2021 changed the title fix: Add user info to suspended node when resuming feat: Add user info to suspended node when resuming Sep 12, 2023
@toyamagu-2021
Copy link
Member Author

Surely, changed!

@terrytangyuan terrytangyuan merged commit 6399ac7 into argoproj:master Sep 12, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/suspend-resume Suspending and resuming workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants