-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add an example field to argo archive list command. Fixes #11898 #12110
docs: Add an example field to argo archive list command. Fixes #11898 #12110
Conversation
Signed-off-by: Shubham <[email protected]>
Signed-off-by: Shubham <[email protected]>
Signed-off-by: Shubham <[email protected]>
Signed-off-by: Shubham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codegen failed
Signed-off-by: Shubham <[email protected]>
Signed-off-by: Shubham <[email protected]>
Signed-off-by: Shubham <[email protected]>
@agilgur5 Could you help point out where and why the codegen test is failing? I used the same spacing format as before for the other command, but it is still failing!! |
# List Archived Workflows with a specific chunk size: | ||
argo archive list --chunk-size <chunk_size> | ||
|
||
# List Archived Workflows with the specified label (used to filter archived workflows): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't match the modified description (you changed it to label_s_, plural)
argo archive list --chunk-size <chunk_size> | ||
|
||
# List Archived Workflows with the specified label (used to filter archived workflows): | ||
argo archive list -l key1=value1,key2=value2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argo archive list -l key1=value1,key2=value2 | |
argo archive list -l key1=value1,key2=value2 | |
a new line at the end is generated
``` | ||
# List all Archived Workflows: | ||
argo archive list | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codegen is erroring on the whitespace here because you have trailing whitespace in the code, but not in the generated docs.
Can you get make codegen
to run on its own (i.e. without running make pre-commit
)?
that will make things a lot simpler than trying to manually match up to what codegen
expects
Co-authored-by: Anton Gilgur <[email protected]> Signed-off-by: Shubham <[email protected]>
Co-authored-by: Anton Gilgur <[email protected]> Signed-off-by: Shubham <[email protected]>
This PR has been automatically marked as stale because it has not had recent activity and needs further changes. It will be closed if no further activity occurs. |
This PR has been closed due to inactivity and lack of changes. If you would like to still work on this PR, please address the review comments and re-open. |
Superseded by #13662 |
Fixes #11898
Motivation
Changes to support more detailed information when the user runs the argo archive list command
Modifications
Added examples for some common usages of argo archive list command
Verification
RUN
argo archive list --help