build(ui): remove no longer needed --openssl-legacy-provider
#12480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this was needed for Webpack v4, but as of aac4f89, we are on Webpack v5 and so this is no longer necessary - and this is more secure too, as the legacy option was insecure - basically undoes the parts of d876464 that added `--openssl-legacy-provider` Signed-off-by: Anton Gilgur <[email protected]>
agilgur5
added
area/ui
area/build
|
I’m trying to remember why this was added, but I think if the build passes, this is good to go. |
|
I wrote why it was added and why it is no longer needed in my PR description (and the build also passes) |
jmeridth
approved these changes
Jan 9, 2024
7 tasks
terrytangyuan
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remembered that this was no longer needed after argoproj/argo-ui#432 (comment), I must've forgot I could remove this earlier (or that the flags were even there)
Modifications
--openssl-legacy-provider--openssl-legacy-providerflagsVerification
yarn buildstill works fineyarn startstill works fine