-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add proxy support to CLI API client #12527
base: main
Are you sure you want to change the base?
Conversation
17ce132
to
d78c157
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests in apiclient_test.go and facade_test.go? Thanks
Okay, thanks. I'll give it a try. However, it might take me some time. |
42130cf
to
5103e5a
Compare
Signed-off-by: shimako55 <[email protected]>
…returned based on configuration Signed-off-by: shimako55 <[email protected]>
5103e5a
to
b69677d
Compare
@isubasinghe |
Oops, this isn't implemented there. |
Fixes #10794
Motivation
Issue:
In the current version of Argo Workflows, the API client does not function properly in environments that use a proxy server.
Purpose:
This PR aims to modify the Argo Workflows API client to ensure it functions correctly when routing through a proxy server.
Modifications
Summary of Changes:
Made modifications in
cmd/argo/commands/client/conn.go
,pkg/apiclient/apiclient.go
,pkg/apiclient/http1-client.go
, andpkg/apiclient/http1/facade.go
.Specific Changes:
Added proxy functionality using
http.ProxyURL
.Integrated new proxy settings into the API client construction process.
Added proxy settings to the configuration of
http.Client
andhttp.Transport
.Reason for Changes:
To support the operation of the API client in proxy environments.
Verification
Testing Method:
Conducted manual tests in an environment with a configured proxy server.
Test Results:
Confirmed that the API client operates correctly when routing through a proxy.
Reproduction Steps:
Replace http://example.com:8080 with your actual proxy server URL in the following commands:
or