Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): use router navigation instead of page load after submit #12950

Merged
merged 1 commit into from
Apr 21, 2024
Merged

fix(ui): use router navigation instead of page load after submit #12950

merged 1 commit into from
Apr 21, 2024

Commits on Apr 18, 2024

  1. fix(ui): use router navigation instead of page load after submit 

    - `document.location.href` causes the browser to load a new page which is a full page load
  - `navigation.goto` should always be used when we're routing within the single-page app (SPA)
    - this only changes the internal route so only the next component needs to render, not the entire page
      - (and user-facing `history`, same as changing the `location`)

- fix `name` and `namespace` in Workflow Details to actually change when the URL changes
  - they were previously set as `state` despite not actually being `state`, meaning they only ever received the initial URL and no further changes
    - in particular, this is required for a resubmit to work, as it re-routes to the same component, but with a different URL

- some other tiny code style optimizations in surrounding code

Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c6cb248 View commit details
    Browse the repository at this point in the history