-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consistently set executor log options #12979
base: main
Are you sure you want to change the base?
Conversation
- for all commands, including `emissary`, `agent`, `resource`, and `data` - set loglevel, gloglevel, and log format - replace `getExecutorLogLevel` helper with `getExecutorLogOpts` helper - also add a helper in `/util/cmd` to get the gloglevel Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also comment in the CLIs
that gloglevel
is k8s go-client logging level range 0-10
You mean making this line more specific? I didn't change the option in this PR, just made it actually used, but could improve that for sure, especially as it is for the |
Merged |
Fixes #12788, Fixes #12929 (comment)
Motivation
Modifications
for all commands, including
emissary
,agent
,resource
, anddata
replace
getExecutorLogLevel
helper withgetExecutorLogOpts
helperadd a helper in
util/cmd/glog.go
to get the gloglevelVerification
Existing tests pass