-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dag): Running
hooks should be able to refer to output of earlier tasks
#13639
base: main
Are you sure you want to change the base?
Conversation
98afbbc
to
919da16
Compare
Running
hooks should be able to refer to output of earlier tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find!
Can you add a test or two (negative and positive case) for this?
Also please note how I changed the title of your PR -- the PR commit should state what it does, not the problem. The issue states the problem, the PR states the fix
Also @chengjoey would you be interested in becoming an Argoproj Member? I can sponsor you and I'm sure we can get another sponsor too. Appreciate your contributions and hope to see more! |
okay, i will add tests soon |
yeah, thanks! @agilgur5 |
919da16
to
25be232
Compare
done~ |
82a311e
to
de33ef6
Compare
…earlier tasks Signed-off-by: joey <[email protected]>
de33ef6
to
68e7982
Compare
Fixes #13619
Motivation
running task in a dag template don't have outputs, scope has earlier tasks outputs
resolveExitTmplArgument
will check if outputs is empty, so we don't need to check it upstream of the functionargo-workflows/workflow/controller/exit_handler.go
Lines 54 to 71 in 2dac126