ci: follow-ups + fix flaky Windows http artifact tests. Fixes #12744 #13670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the comments from argoproj#13660. Also, it hopefully fixes the flaky `CI / Windows Unit Tests (pull_request)` test suite. The errors indicate it's trying to write temp files to `/tmp`: ``` --- FAIL: TestArtifactoryArtifactDriver_Load/Found (0.00s) http_test.go:75: Error Trace: D:/a/argo-workflows/argo-workflows/workflow/artifacts/http/http_test.go:75 Error: Received unexpected error: open /tmp/found: The system cannot find the path specified. Test: TestArtifactoryArtifactDriver_Load/Found ``` which obviously isn't the right directory under Windows, but the test does pass sometimes, and it seems like writing to the wrong directory would cause consistent failures. Regardless, the tests should be using `os.CreateTemp()` for this anyway. Signed-off-by: Mason Malone <[email protected]>
Signed-off-by: Mason Malone <[email protected]>
Signed-off-by: Mason Malone <[email protected]>
Joibel
approved these changes
Sep 27, 2024
agilgur5
changed the title
agilgur5
changed the title
agilgur5
changed the title
|
Thanks for the follow-ups and attempt to fix the WIndows flake!
For posterity, Mason asked about this on Slack and noted that #12071 in this file used |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12744 (hopefully)
Motivation
This addresses the comments from #13660. Also, it hopefully fixes the flaky
CI / Windows Unit Tests (pull_request)test suite, but this is kind of a shot in the dark.Modifications
The errors from
CI / Windows Unit Tests (pull_request)indicate it's trying to write temp files to/tmp:which obviously isn't the right directory under Windows, but the test does pass sometimes, and it seems like writing to the wrong directory would cause consistent failures. Regardless, the tests should be using
os.MkdirTemp()for this anyway.Verification
Will check action output