Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): add example argo archive list-label-keys #13706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Junseokee
Copy link

Fixes #11898

Motivation
Modify the argo archive list-label-keys command for more information

Modifications
Added examples for the argo archive list-label-keys command.

Verification
run argo archive list-label-keys -h

@agilgur5
Copy link
Member

agilgur5 commented Oct 14, 2024

Similar to #13707 (comment), it looks like this is a near verbatim copy of #13676? If you are copying someone else's code, title, or description, please make sure to cite and credit your source. This makes no mention of #13676 currently, while copying its description entirely yet missing all the formatting (the title and description are therefore worse than the formatted and edited ones as well). DCO is also failing here

@leehosu was this done with your permission?

@agilgur5 agilgur5 added area/cli The `argo` CLI area/docs Incorrect, missing, or mistakes in docs solution/duplicate This issue or PR is a duplicate of an existing one labels Oct 14, 2024
@leehosu
Copy link
Contributor

leehosu commented Oct 14, 2024

@agilgur5 Yes, as mentioned in #13682 (comment), I am leading the open source project of argoproj in Korea, and I am providing a guide to those who contribute for the first time. This PR was also done under my guide.

@agilgur5
Copy link
Member

Thanks for confirming. I figured since you commented in #13707 (comment) that it was, but as you were not mentioned in the PR description, it was not clear.

Thanks for encouraging more people to contribute! If it's attributed correctly (you should be co-author and your PR linked) and passes CI, I'm happy to merge these. I'm not against merging your original PRs either, but I appreciate you trying to get others involved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli The `argo` CLI area/docs Incorrect, missing, or mistakes in docs solution/duplicate This issue or PR is a duplicate of an existing one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add examples to commands' --help output
3 participants