fix(controller): handle case of configmap already exists on offload EnvVarTemplate. Fixes #13755 #13756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joibel
requested changes
Oct 15, 2024
fyp711
force-pushed
the
offload_env
branch
2 times, most recently
from
fcb5c08
to
9b49595
Compare
Joibel
requested changes
Oct 15, 2024
…VarTemplate Signed-off-by: Yuping Fan <[email protected]>
Joibel
approved these changes
Oct 15, 2024
|
Thanks for this, and for testing 3.6 |
agilgur5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13755
Motivation
if workflow pod used offload envVarTemplate, when pod create failed, and a transient error occurred. The pod will retry on moment, then this node will failed with IsAlreadyExists error.
Modifications
We should process
Already ExistserrorVerification
The best way to verifiy is constructing a too lang template, and than simulate a transient error