Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add deprecations to upgrading guide #13757

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

Joibel
Copy link
Member

@Joibel Joibel commented Oct 15, 2024

Motivation

#13735 and #13719 highlighted and made some deprecations we'd like to remove in a future release.

Modifications

To aid in ensuring users notice this also add a brief note on them to the upgrading guide.

Verification

Links work:
image

@Joibel Joibel added the area/docs Incorrect, missing, or mistakes in docs label Oct 15, 2024
@Joibel Joibel marked this pull request as ready for review October 15, 2024 10:12
docs/upgrading.md Outdated Show resolved Hide resolved
Signed-off-by: Alan Clucas <[email protected]>
Copy link
Member

@isubasinghe isubasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Joibel Joibel merged commit b5a7a88 into argoproj:main Oct 17, 2024
16 checks passed
@Joibel Joibel deleted the upgrading-deprecations branch October 17, 2024 07:21
@@ -5,6 +5,15 @@ the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summar

## Upgrading to v3.6

### Deprecations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should similarly follow order of importance like with #13720 (comment) et al. Deprecations would be less important than breakage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants