fix: better error message for multiple workflow controllers running #13760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per various GitHub issues and personal experience, the "expected < 2 pods, got 2 - this is a bug" error message mostly happens these days when users accidentally have multiple workflow controllers running. This is usually caused by a bad install, e.g. installing a cluster-wide Argo Workflows alongside a namespace-scoped one, and having both controllers reconciling Workflows. Improve the error message to advise users to check for this. Signed-off-by: Greg Sheremeta <[email protected]>
3 tasks
tooptoop4
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Per various GitHub issues and personal experience, the "expected < 2 pods, got 2 - this is a bug" error message mostly happens these days when users accidentally have multiple workflow controllers running. This is usually caused by a bad install, e.g. installing a cluster-wide Argo Workflows alongside a namespace-scoped one, and having both controllers reconciling Workflows.
Modifications
Improve the error message to advise users to check for this.
Verification
I didn't verify this, since it's just a text change.