Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: guidance on PR change request timeliness and PR takeover #13762

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Joibel
Copy link
Member

@Joibel Joibel commented Oct 15, 2024

Motivation

Document something that I think we already kind of do with regard to getting PRs reviewed.

This is somewhat to show we accept PR takeovers, in case someone is willing to pick up an PR but doesn't think they're allowed to.

Modifications

Add a section on Timeliness to the contributing guidelines suggesting the process for taking over a PR and ensuring credits go to the appropriate person.

Verification

docs only: Checked in github markdown.

@Joibel Joibel added area/docs Incorrect, missing, or mistakes in docs area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix labels Oct 15, 2024
@Joibel Joibel marked this pull request as ready for review October 15, 2024 15:16
@agilgur5 agilgur5 changed the title docs: guidance on change requests in PRs docs: guidance on PR change requests timeliness and PR takeover Oct 15, 2024
Copy link
Member

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is somewhat to show we accept PR takeovers, in case someone is willing to pick up an PR but doesn't think they're allowed to.

suggesting the process for taking over a PR and ensuring credits go to the appropriate person.

I think this makes sense to document since we do get these questions and make these suggestions, although the tone currently reads more "rule" than "suggested process". I think the credit part is the only thing that should be a firm "rule" (and also proper copyright/attribution/courtesy/respect/OSS norm/etc).

Also would be good to mention the problem/more information needed label here as well, since it does apply to PRs and the specific case of authors not responding timely.

I can make more specific language suggestions later

@agilgur5 agilgur5 changed the title docs: guidance on PR change requests timeliness and PR takeover docs: guidance on PR change request timeliness and PR takeover Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants