refactor: remove util/slice and use standard slices library
#13775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joibel
changed the title
util/slice and use standard slices library
Joibel
force-pushed
the
util-slice-removal
branch
from
18d80f1 to
4ff7fd6
Compare
Signed-off-by: Alan Clucas <[email protected]>
Joibel
force-pushed
the
util-slice-removal
branch
from
4ff7fd6 to
dc011a9
Compare
agilgur5
approved these changes
Oct 24, 2024
| return append(ret, slice[i+1:]...) | ||
| } | ||
| } | ||
| return slice |
There was a problem hiding this comment.
I assume that you decided that it wasn't worth keeping this file for a simplified version of this helper that uses DeleteFunc? i.e. return slices.DeleteFunc(slice, func (x string) bool { return x == element }
There was a problem hiding this comment.
I considered it, but didn't do it as:
- It behaves differently from the original (modifying the input slice in place). This is sort of surprising, as it also returns the resulting slice. The
slicesversion documents this for us. RemoveString()only operated on arrays ofstrings, not generic arrays, so overall encouraging it to stay around and potentially get duplicated to addRemoveMyOtherType()was worse long term. Possibly genericing it would have been useful, but probably worse as a long term option.
There was a problem hiding this comment.
Yea I considered making it a generic RemoveElement as well.
Thanks for noting this; I don't have a strong opinion on this but wanted to make sure the rationale was documented since the decision seemed intentional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
/util/slicescan be replaced by the official slices library added in go 1.21. This library is also the official version ofgolang.org/x/exp/slices.Replace all uses of these libraries with slices
Modifications
Replace
slice.ContainsString()withslices.Contains(). This is very simple.Replace
slice.RemoveString()withslices.DeleteFunc(), which involves a small inline boolean comparison function.RemoveStringreturned a copy of the slice,DeleteFuncmodifies the slice in place. In the one case where we're using RemoveString to clone the slice (getPodCleanupPatch),slices.Clone()it before modifying.Also fix a test name with a spelling mistake.
Verification
Test suite to catch the problems