Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: migrate argo_archived_workflows.workflow to jsonb #13779

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix!: migrate argo_archived_workflows.workflow to jsonb #13779

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ded3409
fix: remove JSON cast when querying archived workflows
MasonM Oct 17, 2024
77510ad
fix: migrate argo_archived_workflows.workflow to JSONB. Fixes #13601
MasonM Oct 17, 2024
85d094d
Merge branch 'main' into fix-migrate-jsonb
MasonM Oct 19, 2024
f25960a
fix: minor adjustments to comment
MasonM Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions persist/sqldb/migrate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ type change interface {
apply(session db.Session) error
}

type noop struct{}

func (s noop) apply(session db.Session) error {
return nil
}

func ternary(condition bool, left, right change) change {
if condition {
return left
Expand Down Expand Up @@ -258,6 +264,11 @@ func (m migrate) Exec(ctx context.Context) (err error) {
// add indexes for list archived workflow performance. #8836
ansiSQLChange(`create index argo_archived_workflows_i4 on argo_archived_workflows (startedat)`),
ansiSQLChange(`create index argo_archived_workflows_labels_i1 on argo_archived_workflows_labels (name,value)`),
// PostgreSQL only: convert argo_archived_workflows.workflow column to JSONB for performance and consistency with MySQL. #13779
ternary(dbType == MySQL,
noop{},
ansiSQLChange(`alter table argo_archived_workflows alter column workflow set data type jsonb using workflow::jsonb`),
),
} {
err := m.applyChange(changeSchemaVersion, change)
if err != nil {
Expand Down
Loading