Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Discovery Group and EndpointSlice as Constants #596

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AnkurManna
Copy link

argo-cd issue argoproj/argo-cd#18857

@AnkurManna AnkurManna force-pushed the enhancement/skip-reconciliation-endpointslice branch from c7d8ef1 to f80a723 Compare July 1, 2024 14:08
@AnkurManna
Copy link
Author

Please review this pr, as only after merging this i will be able to use these changes in argo-cd repo like https://argo-cd.readthedocs.io/en/stable/developer-guide/dependencies/ for the final pr.

const (
ServiceDiscoveryGroup = "discovery.k8s.io"
ServiceDiscoveryEndpointSliceKind = "EndpointSlice"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not necessary, as this is too specific, i.e. we don't want to potentially add any possible group to this library. My opinion is to just hard-code group and kind in the ArgoCD repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants