Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github actions versions and warnings #639

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

jmeridth
Copy link
Member

- [x] upgrade github/actions/cache GitHub Action to latest
 - this fixings the following warnings (example list [here](https://github.com/argoproj/gitops-engine/actions/runs/11885468091)):
   - Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/[email protected]. Please update your workflow to use the latest version of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/
   - The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
   - The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
- [x] update dependabot config
  - prefix PRs with `chore(deps)`
  - group non major version updates into 1 PR

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth force-pushed the jm_fix_actions_issues branch from a508957 to a4af3cd Compare November 18, 2024 04:10
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.26%. Comparing base (fa0e8d6) to head (a4af3cd).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
- Coverage   55.91%   54.26%   -1.66%     
==========================================
  Files          42       64      +22     
  Lines        4900     6164    +1264     
==========================================
+ Hits         2740     3345     +605     
- Misses       1937     2549     +612     
- Partials      223      270      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmeridth jmeridth self-assigned this Nov 18, 2024
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
more secure, as tags are mutable

Signed-off-by: jmeridth <[email protected]>
Copy link
Member

@rumstead rumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit d948e6b into argoproj:master Dec 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants