Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(eos_cli_config_gen): Restructure molecule host vars part6 #4712

Draft
wants to merge 6 commits into
base: devel
Choose a base branch
from

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Nov 12, 2024

Change Summary

Restructure molecule host vars for below hosts.

HOSTS
router-isis
router-isis-new
router-isis-1
router-isis-2
router-ospf
spanning-tree
snmp-traps
snmp
spanning-tree-bpdu
spanning-tree-rapid-pvst
spanning-tree-rstp

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Restructure molecule host vars part6

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4712
# Activate the virtual environment
source test-avd-pr-4712/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/molecule-2#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/molecule-2 --force
# Optional: Install AVD examples
cd test-avd-pr-4712
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Nov 12, 2024
@laxmikantchintakindi laxmikantchintakindi force-pushed the refactor/molecule-2 branch 4 times, most recently from 8c75ff7 to 404ee49 Compare November 13, 2024 08:23
vrf: MGMT
ip_address: 10.73.254.11/24
gateway: 10.73.254.253

### VLAN Interfaces ###
vlan_interfaces:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move vlan interfaces from this host

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in ospf host there are ethernet, port-channel and vlan interfaces keys are there. Please move to specific hosts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved.

@@ -1,3 +1,4 @@
---
### Spanning-Tree (MST settings)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont see any file changes for host3.cfg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@@ -163,14 +163,6 @@ loopback_interfaces:
ipv4_index: 10
ipv6_index: 1000

### Management Interfaces ###
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the duplicate config for isis with respect to all 4 hosts. Add the host only in case config is not supported with each other

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I added more host as they were required for different isis_authentication under router_isis

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Nov 13, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 13, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

sonarcloud bot commented Nov 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants