-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI(eos_cli_config_gen): Restructure molecule host vars part6 #4712
base: devel
Are you sure you want to change the base?
CI(eos_cli_config_gen): Restructure molecule host vars part6 #4712
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4712
# Activate the virtual environment
source test-avd-pr-4712/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/molecule-2#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/molecule-2 --force
# Optional: Install AVD examples
cd test-avd-pr-4712
ansible-playbook arista.avd.install_examples |
8c75ff7
to
404ee49
Compare
vrf: MGMT | ||
ip_address: 10.73.254.11/24 | ||
gateway: 10.73.254.253 | ||
|
||
### VLAN Interfaces ### | ||
vlan_interfaces: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move vlan interfaces from this host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also in ospf host there are ethernet, port-channel and vlan interfaces keys are there. Please move to specific hosts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved.
@@ -1,3 +1,4 @@ | |||
--- | |||
### Spanning-Tree (MST settings) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont see any file changes for host3.cfg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
@@ -163,14 +163,6 @@ loopback_interfaces: | |||
ipv4_index: 10 | |||
ipv6_index: 1000 | |||
|
|||
### Management Interfaces ### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove the duplicate config for isis with respect to all 4 hosts. Add the host only in case config is not supported with each other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I added more host as they were required for different isis_authentication under router_isis
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
7e50aa5
to
554b228
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
077db20
to
e5d89f9
Compare
Quality Gate passedIssues Measures |
Change Summary
Restructure molecule host vars for below hosts.
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Restructure molecule host vars part6
How to test
Checklist
User Checklist
Repository Checklist